Support ruby 3 and kwargs #1158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're going to need to explicitly separate kwargs and hash parameters to fix ruby 3 compatibility
|
@jdelStrother Could you fix the conflicts in this PR to make it mergable? This is working great for me on a Ruby 3.1 project, and I'd love to see it get released. |
|
If the maintainers are interested in merging this I’ll fix up the conflicts, but I’m no longer using DJ. Feel free to take over this branch if you’re more invested |
This was referenced May 12, 2022
Closed
This was referenced Nov 30, 2023
|
You should also pass add delayed_job/lib/delayed/message_sending.rb Lines 39 to 50 in b66bb64 |
|
I use this in production: define_method(with_method) do |*args, **kwargs|
curr_opts = opts.clone
curr_opts.each_key do |key|
next unless (val = curr_opts[key]).is_a?(Proc)
curr_opts[key] = if val.arity == 1
val.call(self)
else
val.call
end
end
delay(curr_opts).__send__(without_method, *args, **kwargs)
end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the work @webhoernchen started in #1130.
We've been running this in production for a month while upgrading an installation from ruby 2.7 to 3.0 without issue. I think I've managed to keep support for ruby 2.6, but haven't done much more than run the test suite on it.